fix: don't propagate future mtimes #49551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
Altahrim,
ArtificialOwl and
provokateurin
and removed request for
a team
icewind1991
force-pushed
the
dont-propagate-future-time
branch
from
3e42229 to
86719a8
Compare
provokateurin
approved these changes
Nov 28, 2024
icewind1991
force-pushed
the
dont-propagate-future-time
branch
from
86719a8 to
d41983f
Compare
Member
Author
|
reverted the constructor argument changes, was causing to much splash damage |
icewind1991
force-pushed
the
dont-propagate-future-time
branch
from
d41983f to
8c7bd01
Compare
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
dont-propagate-future-time
branch
from
8c7bd01 to
aadfcb3
Compare
Collaborator
I didn't saw the "splash", do you think we could backport this and add clock in constructor for |
9 tasks
skjnldsv
approved these changes
Dec 4, 2024
This was referenced Dec 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading a file with an mtime in the future the parent folders also get the future timestamp.
This clamps the propagated mtime to the current one to prevent this.
to test:
touch -d "now +1 year" test.txttesttest.txtinto thetestfoldertestfolder