Skip to content

fix(external_storage): Cast id to int #49602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 2 commits into from
Dec 3, 2024
Merged

fix(external_storage): Cast id to int #49602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c284e49
fix(external_storage): Cast id to int
oleksandr-nc Dec 2, 2024
1022c47
Merge branch 'master' into fix/external-storage-service-cast-id
oleksandr-nc Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/files_external/lib/Service/StoragesService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ protected function readConfig() {
* @return StorageConfig
* @throws NotFoundException if the storage with the given id was not found
*/
public function getStorage($id) {
public function getStorage(int $id) {
$mount = $this->dbConfig->getMountById($id);

if (!is_array($mount)) {
Expand Down Expand Up @@ -433,7 +433,7 @@ public function updateStorage(StorageConfig $updatedStorage) {
*
* @throws NotFoundException if no storage was found with the given id
*/
public function removeStorage($id) {
public function removeStorage(int $id) {
$existingMount = $this->dbConfig->getMountById($id);

if (!is_array($existingMount)) {
Expand Down
Loading