Skip to content

[stable29] fix: promote re-shares when deleting the parent share #49630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
backportbot wants to merge 10 commits into from
Closed

[stable29] fix: promote re-shares when deleting the parent share #49630

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4e3b6fd
fix: delete re-shares when deleting the parent share
luka-nextcloud Aug 7, 2024
3aa21e2
fix: Tidy up code for reshare deletion
come-nc Aug 22, 2024
8efc715
fix: Transfer incomming shares first, do not delete non-migratable ones
come-nc Aug 26, 2024
c1dca15
fix(shares): Promote reshares into direct shares when share is deleted
come-nc Sep 13, 2024
8284a0a
chore: Turn method description into phpdoc
come-nc Sep 15, 2024
7628179
chore: Add comment to make code clearer
come-nc Sep 16, 2024
5db7b2f
fix(tests): Fix share tests to test new reshare promotion system
come-nc Oct 3, 2024
1312611
fix(tests): Revert changes to tests now that reshares are not deleted…
come-nc Oct 8, 2024
0655ead
fix: Fix promotion of reshares from subsubfolders
come-nc Oct 14, 2024
99b254b
fix: Use getRelativePath method to check if node is inside folder
come-nc Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Add comment to make code clearer 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc @backportbot
come-nc authored and backportbot[bot] committed Dec 3, 2024
commit 7628179940717ad02286117fdabb52fe228ab956
1 change: 1 addition & 0 deletions lib/private/Share20/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,6 +1223,7 @@ protected function promoteReshares(IShare $share): void {

foreach ($reshareRecords as $child) {
try {
/* Check if the share is still valid (means the resharer still has access to the file through another mean) */
$this->generalCreateChecks($child);
} catch (GenericShareException $e) {
/* The check is invalid, promote it to a direct share from the sharer of parent share */
Expand Down