-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[stable30] enh: Improvements on sharing details #49631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Dec 4, 2024
857dfb7 to
f71aab2
Compare
nfebe
approved these changes
Dec 5, 2024
Contributor
|
/backport to stable29 |
Contributor
|
/compile |
Merged
2da8203 to
e939902
Compare
Contributor
|
/compile |
Member
|
many failures |
e939902 to
6f7e34a
Compare
Contributor
|
/compile |
Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]> [skip ci]
ShareType lists both names and ids so Object.entries return too much. This was also making useless the following condition adding ShareType.Email Signed-off-by: Louis Chemineau <[email protected]>
bad622d to
377068e
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #49351
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.