Skip to content

Conversation

@provokateurin
Copy link
Member

Summary

Simple follow-up to #49073.

Checklist

@Altahrim Altahrim removed the 3. to review Waiting for reviews label Dec 4, 2024
@Altahrim Altahrim merged commit c77243d into master Dec 4, 2024
191 checks passed
@Altahrim Altahrim deleted the feat/files_external/enable-ownerless-shares branch December 4, 2024 13:58
@come-nc
Copy link
Contributor

come-nc commented Dec 4, 2024

@provokateurin A comment explaining what the class is would help.
SystemMountPoint is for mounts configured by admin and available for several users, while PersonalMount is for mounts added by user themselves in their tree?
What about class ExternalMountPoint, it should be abstract, no?

@provokateurin
Copy link
Member Author

SystemMountPoint is for mounts configured by admin and available for several users, while PersonalMount is for mounts added by user themselves in their tree?

Yes

What about class ExternalMountPoint, it should be abstract, no?

It implements some of the methods, so I think this is how it should be 🤷‍♀️

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants