Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3ebab0d
refactor(files_sharing): move deprecated projects component
thlehmann-ionos Nov 7, 2024
e63c9c0
refactor(files_sharing): split internal/external share (relayout)
thlehmann-ionos Aug 7, 2024
5df6fb2
refactor(files_sharing): add another user search input in external sh…
thlehmann-ionos Nov 7, 2024
0a721a3
refactor(files_sharing): dissolve component SharingEntryLink into Sha…
thlehmann-ionos Nov 7, 2024
2fb95df
[DROP] Recompile for files_sharing changes
thlehmann-ionos Dec 4, 2024
642d623
[POC] [WIP] refactor(files_sharing): move getSuggestions(), getRecomm…
thlehmann-ionos Dec 5, 2024
a9507ea
[DROP] Recompile for files_sharing changes
thlehmann-ionos Dec 5, 2024
b4f6b1d
Revert "[DROP] Recompile for files_sharing changes"
thlehmann-ionos Dec 6, 2024
c17261e
Revert "[POC] [WIP] refactor(files_sharing): move getSuggestions(), g…
thlehmann-ionos Dec 6, 2024
818af87
AMEND TO: 'refactor(files_sharing): dissolve component SharingEntryLi…
thlehmann-ionos Dec 6, 2024
e623446
chore(files_sharing): fix inconsistent trim() of shareWith
thlehmann-ionos Dec 6, 2024
4ac858c
chore(files_sharing): replace reduce() by flat()
thlehmann-ionos Dec 6, 2024
ecd31c2
refactor(files_sharing): add ShareTypes module
thlehmann-ionos Dec 6, 2024
0ba6f7b
[WIP] refactor(files_sharing): extract formatForMultiselect() from Sh…
thlehmann-ionos Dec 6, 2024
8d66704
[WIP] feat(files_sharing): add ExternalShareeSearch
thlehmann-ionos Dec 6, 2024
ac8a857
[WIP] feat(files_sharing): use external sharee search
thlehmann-ionos Dec 6, 2024
0c71e8b
[WIP] feat(files_sharing): remove lookup, limit to internal shares
thlehmann-ionos Dec 6, 2024
e42d673
[DROP] Recompile for files_sharing changes
thlehmann-ionos Dec 6, 2024
01ec6d0
[WIP] Note: work in progress
thlehmann-ionos Nov 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(files_sharing): fix inconsistent trim() of shareWith
shareWith is below used _trimmed_ to index the field of the
shareWith-to-type mapping; thus, create the key trimmed too.

Why trimming is done here is questionable though.

Refs: #48925

Signed-off-by: Thomas Lehmann <[email protected]>
  • Loading branch information
thlehmann-ionos committed Dec 6, 2024
commit e62344610489dd9137900f266cbfe6e75c019ad3
2 changes: 1 addition & 1 deletion apps/files_sharing/src/components/SharingInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ export default {
} else { // filter out existing shares
// creating an object of uid => type
const sharesObj = this.shares.reduce((obj, elem) => {
obj[elem.shareWith] = elem.type
obj[elem.shareWith.trim()] = elem.type
return obj
}, {})

Expand Down