Skip to content

fix(federation): Allow Oracles empty strings #49750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Dec 10, 2024
Merged

fix(federation): Allow Oracles empty strings #49750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/unstable/Security/Signature/Model/Signatory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@
* @method void setType(int $type)
* @method int getStatus()
* @method void setStatus(int $status)
* @method void setAccount(string $account)
* @method string getAccount()
* @method void setAccount(?string $account)
* @method void setMetadata(array $metadata)
* @method ?array getMetadata()
* @method void setCreation(int $creation)
Expand All @@ -56,7 +55,7 @@ class Signatory extends Entity implements JsonSerializable {
protected string $host = '';
protected string $publicKey = '';
protected string $privateKey = '';
protected string $account = '';
protected ?string $account = '';
protected int $type = 9;
protected int $status = 1;
protected ?array $metadata = null;
Expand Down Expand Up @@ -145,6 +144,13 @@ public function getSignatoryStatus(): SignatoryStatus {
return SignatoryStatus::from($this->getStatus());
}

/**
* @experimental 31.0.0
*/
public function getAccount(): string {
return $this->account ?? '';
}

/**
* update an entry in metadata
*
Expand Down
Loading