-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Create a temp certfile #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a temp certfile #4984
Conversation
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @schiessle to be potential reviewers. |
| * @return bool | ||
| */ | ||
| private function needsRebundling($uid = '') { | ||
| return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should not be in here 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rullzer ping
Codecov Report
@@ Coverage Diff @@
## master #4984 +/- ##
============================================
- Coverage 53.76% 7.42% -46.35%
+ Complexity 22747 22274 -473
============================================
Files 1405 1379 -26
Lines 86879 84649 -2230
Branches 1328 1322 -6
============================================
- Hits 46713 6284 -40429
- Misses 40166 78365 +38199
|
Codecov Report
@@ Coverage Diff @@
## master #4984 +/- ##
============================================
- Coverage 53.76% 30.8% -22.97%
+ Complexity 22747 22746 -1
============================================
Files 1405 1405
Lines 86879 86282 -597
Branches 1328 1328
============================================
- Hits 46713 26581 -20132
- Misses 40166 59701 +19535
|
|
Ok... I just tried certfile regeneration 30 times on a host that had the issues... all worked... so lets pray it now works good enough... Should backport to stable12 @LukasReschke @MorrisJobke @nickvergessen @icewind1991 please review |
Signed-off-by: Roeland Jago Douma <[email protected]>
Hopefully fixes or at leasts gives some more insights into #3470
@LukasReschke as discussed...
More debugging later.