Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented May 19, 2017

Hopefully fixes or at leasts gives some more insights into #3470

@LukasReschke as discussed...

More debugging later.

@rullzer rullzer added 2. developing Work in progress bug high labels May 19, 2017
@rullzer rullzer added this to the Nextcloud 12.0 milestone May 19, 2017
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @schiessle to be potential reviewers.

* @return bool
*/
private function needsRebundling($uid = '') {
return true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should not be in here 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rullzer ping

@codecov
Copy link

codecov bot commented Jul 12, 2017

Codecov Report

Merging #4984 into master will decrease coverage by 46.34%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #4984       +/-   ##
============================================
- Coverage     53.76%   7.42%   -46.35%     
+ Complexity    22747   22274      -473     
============================================
  Files          1405    1379       -26     
  Lines         86879   84649     -2230     
  Branches       1328    1322        -6     
============================================
- Hits          46713    6284    -40429     
- Misses        40166   78365    +38199
Impacted Files Coverage Δ Complexity Δ
lib/private/App/AppStore/Fetcher/Fetcher.php 0% <ø> (-77.95%) 19 <0> (ø)
lib/private/Security/CertificateManager.php 0% <0%> (-91.84%) 38 <0> (-1)
lib/private/Security/IdentityProof/Key.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Files/Storage/Temporary.php 0% <0%> (-100%) 4% <0%> (ø)
lib/private/App/AppStore/Bundles/Bundle.php 0% <0%> (-100%) 2% <0%> (ø)
apps/files/lib/Activity/Settings/FileRestored.php 0% <0%> (-100%) 8% <0%> (ø)
lib/private/Notification/Action.php 0% <0%> (-100%) 24% <0%> (ø)
...rivate/Authentication/Token/DefaultTokenMapper.php 0% <0%> (-100%) 11% <0%> (ø)
lib/private/Files/ObjectStore/Mapper.php 0% <0%> (-100%) 2% <0%> (ø)
lib/private/Repair/NC11/FixMountStorages.php 0% <0%> (-100%) 5% <0%> (ø)
... and 928 more

@codecov-io
Copy link

codecov-io commented Jul 12, 2017

Codecov Report

Merging #4984 into master will decrease coverage by 22.96%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #4984       +/-   ##
============================================
- Coverage     53.76%   30.8%   -22.97%     
+ Complexity    22747   22746        -1     
============================================
  Files          1405    1405               
  Lines         86879   86282      -597     
  Branches       1328    1328               
============================================
- Hits          46713   26581    -20132     
- Misses        40166   59701    +19535
Impacted Files Coverage Δ Complexity Δ
lib/private/Security/CertificateManager.php 0% <0%> (-91.84%) 39 <1> (ø)
lib/private/Server.php 26.56% <0%> (-66.8%) 120 <0> (ø)
lib/private/DB/OCSqlitePlatform.php 0% <0%> (-100%) 5% <0%> (ø)
...s/dav/lib/Connector/Sabre/Exception/FileLocked.php 0% <0%> (-100%) 3% <0%> (ø)
apps/dav/lib/Connector/Sabre/Server.php 0% <0%> (-100%) 1% <0%> (ø)
...s/federatedfilesharing/lib/AppInfo/Application.php 0% <0%> (-100%) 5% <0%> (ø)
...ivate/Files/Cache/Wrapper/CachePermissionsMask.php 0% <0%> (-100%) 3% <0%> (ø)
apps/files_sharing/lib/AppInfo/Application.php 0% <0%> (-100%) 3% <0%> (-1%)
apps/dav/lib/CalDAV/PublicCalendarRoot.php 0% <0%> (-100%) 4% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php 0% <0%> (-100%) 1% <0%> (ø)
... and 375 more

@rullzer
Copy link
Member Author

rullzer commented Jul 12, 2017

Ok... I just tried certfile regeneration 30 times on a host that had the issues... all worked... so lets pray it now works good enough...

Should backport to stable12

@LukasReschke @MorrisJobke @nickvergessen @icewind1991 please review

@rullzer rullzer removed the 2. developing Work in progress label Jul 12, 2017
@rullzer rullzer added the 3. to review Waiting for reviews label Jul 12, 2017
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer merged commit 6461d08 into master Jul 12, 2017
@rullzer rullzer deleted the tmpcertfile branch July 12, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants