Skip to content

fix(files_external): wrong type for external mount id #49843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Altahrim merged 1 commit into from
Dec 13, 2024
Merged

fix(files_external): wrong type for external mount id #49843

Altahrim merged 1 commit into from
Dec 13, 2024

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Dec 13, 2024

Summary

Fix error:

TypeError: OCA\Files_External\Service\StoragesService::getStorage(): Argument #1 ($id) must be of type int, string given, called in /var/www/html/apps/files_external/lib/Command/StorageAuthBase.php on line 70 and defined in /var/www/html/apps/files_external/lib/Service/StoragesService.php:163

Checklist

@Altahrim Altahrim added bug 3. to review Waiting for reviews php Pull requests that update Php code labels Dec 13, 2024
@Altahrim Altahrim added this to the Nextcloud 31 milestone Dec 13, 2024
@Altahrim Altahrim requested a review from a team December 13, 2024 09:29
@Altahrim Altahrim self-assigned this Dec 13, 2024
@Altahrim Altahrim requested review from come-nc, nfebe and skjnldsv and removed request for a team December 13, 2024 09:29
@Altahrim
Copy link
Collaborator Author

Altahrim commented Dec 13, 2024

/backport to stable30

@Altahrim
Copy link
Collaborator Author

Altahrim commented Dec 13, 2024

/backport to stable29

Antreesy
Antreesy approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thanks!

@Altahrim Altahrim enabled auto-merge December 13, 2024 09:44
@solracsf
Copy link
Member

solracsf commented Dec 13, 2024

Tests are broken (no related to this PR). 😿

@Altahrim Altahrim merged commit 10852d3 into master Dec 13, 2024
188 of 191 checks passed
@Altahrim Altahrim deleted the fix/files_external_scan branch December 13, 2024 10:29
This was referenced Dec 13, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsf solracsf solracsf approved these changes

@Antreesy Antreesy Antreesy approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels

3. to review Waiting for reviews bug php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

4 participants

@Altahrim @solracsf @Antreesy