Skip to content

Conversation

@provokateurin
Copy link
Member

Summary

Checklist

@provokateurin provokateurin added this to the Nextcloud 31 milestone Dec 17, 2024
@provokateurin provokateurin requested review from a team, Altahrim, artonge and come-nc and removed request for a team December 17, 2024 08:55
@joshtrichards
Copy link
Member

1) OCA\Settings\Tests\Controller\MailSettingsControllerTest::testSetMailSettings
TypeError: OCA\Settings\Controller\MailSettingsController::setMailSettings(): Argument #8 ($mail_sendmailmode) must be of type string, null given, called in /home/runner/actions-runner/_work/server/server/apps/settings/tests/Controller/MailSettingsControllerTest.php on line 90

I guess mail_sendmailmode needs to be nullable (or the tests updated to pass '' perhaps?)

@provokateurin
Copy link
Member Author

I guess mail_sendmailmode needs to be nullable (or the tests updated to pass '' perhaps?)

Null is not allowed (or at least never sent by the frontend), so the test just needs to use ''.

@provokateurin provokateurin force-pushed the refactor/settings/mail-settings-parameters branch from 6a415b8 to e8e014a Compare January 6, 2025 07:14
@provokateurin provokateurin force-pushed the refactor/settings/mail-settings-parameters branch from e8e014a to 0eedceb Compare January 6, 2025 07:31
@provokateurin provokateurin force-pushed the refactor/settings/mail-settings-parameters branch from 0eedceb to 98275fb Compare January 6, 2025 07:41
@provokateurin provokateurin requested a review from come-nc January 6, 2025 07:41
@skjnldsv skjnldsv merged commit cd236c7 into master Jan 7, 2025
188 checks passed
@skjnldsv skjnldsv deleted the refactor/settings/mail-settings-parameters branch January 7, 2025 15:59
@blizzz blizzz mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants