fix(files): Only register preview service worker once when the instance is hosted at the root path #49917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable30 |
…ce is hosted at the root path Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/files/preview-service-worker-registration
branch
from
9d09868 to
d3bd999
Compare
4 tasks
Contributor
|
/compile |
sorbaugh
approved these changes
Dec 18, 2024
Contributor
|
@provokateurin thank you for catching and fixing this |
Signed-off-by: nextcloud-command <[email protected]>
artonge
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The behavior was changed in #49694, but didn't account for the fact an empty string is returned instead of the assumed
/if the instance is at the root path.I confirmed this now correctly works with instances hosted at the root path and in a subfolder.
Checklist