fix for sharing #4997
Merged
fix for sharing #4997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hansson <[email protected]>
|
@enoch85, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @nickvergessen and @icewind1991 to be potential reviewers. |
enoch85
added
3. to review
Member
Author
|
Can someone backport to 12 and 11 as well please? Didn't figure out how to push to stable12, git said the branch was protected. cc @karlitschek for approval |
Member
|
@enoch85 you need to create a branch based on stable12 and then send a PR against stable12 |
This was referenced May 20, 2017
Member
Author
|
@nickvergessen How do I fix the errors? Timeout... |
Member
|
You don't, its fine |
nickvergessen
approved these changes
May 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Hansson [email protected]
Fixes #3455