Skip to content

fix: Change UserAgent to *cloud #50053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sorbaugh merged 1 commit into from
Feb 21, 2025
Merged

fix: Change UserAgent to *cloud #50053

sorbaugh merged 1 commit into from
Feb 21, 2025

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Jan 6, 2025 •
edited
Loading

Close #50018

Summary

Local and squashed version of #50018

In Automated Tagging Flows there is an option to filter by "Request user agent" which has an option "Thunderbird & Outlook addons". For the Thunderbird Addon this activates a filter for the User-Agent of the old, discontinued Nextcloud for Filelink Add-on. The current Add-on is *cloud - FileLink for Nextcloud and ownCloud which sends its own User-Agent. This patch exchanges the User-Agent of the discontinued Add-on with that of the current one.

TODO

  • CI
  • Review
  • Backports

Checklist

@kesselb kesselb force-pushed the fix/noid/thudnerbird-addon-useragent branch from 338631d to ed55ceb Compare January 16, 2025 16:53
@kesselb kesselb added bug 3. to review Waiting for reviews labels Jan 16, 2025
@kesselb kesselb requested review from a team, icewind1991, nfebe, nickvergessen and skjnldsv and removed request for a team January 16, 2025 16:55
@kesselb kesselb added this to the Nextcloud 31 milestone Jan 16, 2025
@skjnldsv skjnldsv mentioned this pull request Jan 16, 2025
Merged
skjnldsv
skjnldsv approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

nickvergessen
nickvergessen reviewed Jan 17, 2025
View reviewed changes
This was referenced Jan 21, 2025
Merged
Merged
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 25, 2025

/backport to stable31

@kesselb kesselb force-pushed the fix/noid/thudnerbird-addon-useragent branch from ed55ceb to ff3c7e8 Compare January 26, 2025 14:26
@blizzz blizzz mentioned this pull request Jan 29, 2025
Merged
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@kesselb kesselb force-pushed the fix/noid/thudnerbird-addon-useragent branch from ff3c7e8 to ab63ba2 Compare February 14, 2025 15:06
@kesselb kesselb mentioned this pull request Feb 14, 2025
Closed
4 tasks
@kesselb
Copy link
Contributor Author

kesselb commented Feb 14, 2025

/backport to stable30

@kesselb
Copy link
Contributor Author

kesselb commented Feb 14, 2025

/backport to stable29

@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 17, 2025
@joendres @kesselb @AndyScherzinger
fix: Change UserAgent to *cloud
ae2cc23 
Co-authored-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Johannes Endres <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the fix/noid/thudnerbird-addon-useragent branch from ab63ba2 to ae2cc23 Compare February 19, 2025 17:51
@sorbaugh sorbaugh merged commit 33a12eb into master Feb 21, 2025
184 of 189 checks passed
@sorbaugh sorbaugh deleted the fix/noid/thudnerbird-addon-useragent branch February 21, 2025 09:28
This was referenced Feb 21, 2025
Merged
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin provokateurin approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

9 participants

@kesselb @AndyScherzinger @nickvergessen @skjnldsv @provokateurin @blizzz @sorbaugh @joendres