Skip to content

feat(files_sharing): add send mail toggle #50064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nfebe wants to merge 3 commits into from
Closed

feat(files_sharing): add send mail toggle #50064

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9688857
feat(files_sharing): add send mail toggle
nfebe Jan 7, 2025
67c1683
test(files_sharing): Ensure `mailSend` triggers mail functions accord…
nfebe May 14, 2025
5579034
chore(assets): Recompile assets
nextcloud-command Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(files_sharing): Ensure mailSend triggers mail functions accord… 
…ingly

Signed-off-by: nfebe <[email protected]>
  • Loading branch information
@nfebe
nfebe committed Jun 4, 2025
commit 67c1683eecd3278187f07135c80c1238a45f6eaa
97 changes: 97 additions & 0 deletions apps/files_sharing/tests/Controller/ShareAPIControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
* SPDX-FileCopyrightText: 2016 ownCloud, Inc.
Expand Down Expand Up @@ -5233,4 +5234,100 @@ public function testPopulateTags(): void {
['file_source' => 42, 'x' => 'y', 'tags' => ['tag1', 'tag2']],
], $result);
}

public function testCreateShareWithMailNotificationEnabled(): void {
$share = $this->createMock(IShare::class);
$node = $this->getMockBuilder(File::class)->getMock();
$userFolder = $this->getMockBuilder(Folder::class)->getMock();

$storage = $this->createMock(\OCP\Files\Storage\IStorage::class);
$storage->method('instanceOfStorage')
->willReturnMap([
[\OCA\Files_Sharing\External\Storage::class, false],
[\OCA\Files_Sharing\SharedStorage::class, false],
]);

$node->method('getPath')->willReturn('/testfile.txt');
$node->method('getId')->willReturn(1);
$node->method('getStorage')->willReturn($storage);
$userFolder->method('get')
->with('/testfile.txt')
->willReturn($node);
$userFolder->method('getById')
->with(1)
->willReturn([]);
$this->rootFolder->method('getUserFolder')
->with('currentUser')
->willReturn($userFolder);
$this->userManager->method('userExists')->with('recipient')->willReturn(true);
$this->shareManager->method('newShare')->willReturn($share);
$this->shareManager->method('createShare')->with($share)->willReturn($share);
$share->method('getNode')->willReturn($node);

$share->expects($this->once())
->method('setMailSend')
->with(true);

$formattedShare = ['id' => '123'];
$controller = $this->mockFormatShare();
$controller->method('formatShare')
->with($share)
->willReturn($formattedShare);

$result = $controller->createShare(
'/testfile.txt', 1, IShare::TYPE_USER, 'recipient',
null, '', null, null, '', '', null, 'true'
);

$this->assertEquals(\OCP\AppFramework\Http::STATUS_OK, $result->getStatus());
$this->assertEquals($formattedShare, $result->getData());
}

public function testCreateShareWithMailNotificationDisabled(): void {
$share = $this->createMock(IShare::class);
$node = $this->getMockBuilder(File::class)->getMock();
$userFolder = $this->getMockBuilder(Folder::class)->getMock();

$storage = $this->createMock(\OCP\Files\Storage\IStorage::class);
$storage->method('instanceOfStorage')
->willReturnMap([
[\OCA\Files_Sharing\External\Storage::class, false],
[\OCA\Files_Sharing\SharedStorage::class, false],
]);

$node->method('getPath')->willReturn('/testfile.txt');
$node->method('getId')->willReturn(1);
$node->method('getStorage')->willReturn($storage);
$userFolder->method('get')
->with('/testfile.txt')
->willReturn($node);
$userFolder->method('getById')
->with(1)
->willReturn([]);
$this->rootFolder->method('getUserFolder')
->with('currentUser')
->willReturn($userFolder);
$this->userManager->method('userExists')->with('recipient')->willReturn(true);
$this->shareManager->method('newShare')->willReturn($share);
$this->shareManager->method('createShare')->with($share)->willReturn($share);
$share->method('getNode')->willReturn($node);

$share->expects($this->once())
->method('setMailSend')
->with(false);

$formattedShare = ['id' => '123'];
$controller = $this->mockFormatShare();
$controller->method('formatShare')
->with($share)
->willReturn($formattedShare);

$result = $controller->createShare(
'/testfile.txt', 1, IShare::TYPE_USER, 'recipient',
null, '', null, null, '', '', null, 'false'
);

$this->assertEquals(\OCP\AppFramework\Http::STATUS_OK, $result->getStatus());
$this->assertEquals($formattedShare, $result->getData());
}
}
Loading