Skip to content

[master] fix(files): actions submenu papercuts #50126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Jan 10, 2025
Merged

[master] fix(files): actions submenu papercuts #50126

skjnldsv merged 3 commits into from
Jan 10, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jan 10, 2025 •
edited by skjnldsv
Loading

Pulled from #50123

  • Fix an issue where you would still have the previous opened submenu when opening another file's actions menu
  • Use Back to go back one menu up instead of the previous way (raised by @ShGKme, approved by @marcoambrosini)
Before After
image image

@backportbot backportbot bot requested a review from skjnldsv as a code owner January 10, 2025 11:44
@backportbot backportbot bot requested a review from skjnldsv January 10, 2025 11:44
@backportbot backportbot bot added 3. to review Waiting for reviews feature: files labels Jan 10, 2025
@skjnldsv skjnldsv changed the title [master] feat(api): File conversion Files action [master] fix(files): actions submenu papercuts Jan 10, 2025
@skjnldsv skjnldsv requested review from a team, marcoambrosini, nfebe, susnux and szaimen and removed request for a team January 10, 2025 11:47
@skjnldsv skjnldsv added bug papercut Annoying recurring UX issue with possibly simple fix. labels Jan 10, 2025
This was referenced Jan 10, 2025
Merged
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Jan 10, 2025

/compile

@skjnldsv skjnldsv enabled auto-merge January 10, 2025 13:09
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 10, 2025
@nextcloud-command
chore(assets): Recompile assets
24490f3 
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv merged commit 184e715 into master Jan 10, 2025
120 checks passed
@skjnldsv skjnldsv deleted the backport/50123/master branch January 10, 2025 13:27
@skjnldsv skjnldsv mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@susnux susnux Awaiting requested review from susnux

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @marcoambrosini @nextcloud-command