fix(updatenotification): Parse pre-release version of apps #50233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
ArtificialOwl,
JuliaKirschenheuter,
Pytal,
come-nc and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable30 |
come-nc
approved these changes
Jan 20, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
You need to adapt the @return tag and document bad request return code.
Merged
susnux
force-pushed
the
fix/update-notification
branch
from
5c42326 to
4b92dde
Compare
Contributor
Author
Thank you, done! |
susnux
force-pushed
the
fix/update-notification
branch
from
4b92dde to
0854abc
Compare
The notitication is correctly created, but the changelog is not show. We need to make sure the version passed to the manager is in the allowed format (major.minor.patch). Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/update-notification
branch
from
0854abc to
e212f33
Compare
provokateurin
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The notification is correctly created, but the changelog is not show. We need to make sure the version passed to the manager is in the allowed format (major.minor.patch).
Checklist