[stable29] fix(files): hide move dialog action if destination has no CREATE permission #50238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
force-pushed
the
backport/50177/stable29
branch
from
764a649 to
158872d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Antreesy
approved these changes
Jan 17, 2025
skjnldsv
approved these changes
Jan 21, 2025
Signed-off-by: Louis Chemineau <[email protected]>
…ission Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
backport/50177/stable29
branch
from
6e78683 to
cd31ec2
Compare
Contributor
|
/compile / |
…ssion Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Antreesy
force-pushed
the
backport/50177/stable29
branch
from
4b56a1c to
7653f96
Compare
Contributor
|
CI Fail is due to #47185 backport is missing. Only missing bit is this one, though I don't know how much else will be broken: export const canMove = (nodes: Node[]) => {
const minPermission = nodes.reduce((min, node) => Math.min(min, node.permissions), Permission.ALL)
return Boolean(minPermission & Permission.DELETE) // Previously Permission.UPDATE
} |
Contributor
makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45982
Backport of #50177
Backport of #50206
Warning, This backport's changes differ from the original and might be incomplete⚠️