Skip to content

Conversation

@Dennis1993
Copy link
Contributor

Fixes #49682

  • Resolves: #

Summary

Database field is null and we should check it with empt() function to prevent error like this: #49682

Checklist

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also forbids the string '0'.
Moreover this only hides the problem, it should never be null in the first place.

So would be good to investigate why null is set instead of the empty string.

@susnux
Copy link
Contributor

susnux commented Jan 26, 2025

Thank you very much for your contribution!

We resolved it with #50447
Also we should never use empty as there are sideeffects like the mentioned empty('0') === true

@susnux susnux closed this Jan 26, 2025
@susnux susnux deleted the Dennis1993-patch-1 branch January 26, 2025 22:35
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 30.0.3 Log spamming Invalid label data providedInitialState by files_sharing

3 participants