Added parameter to disable web UI integration with local client

[pboguslawski]

Summary

Added system config parameter web_ui_integration_local_client.enabled to allow disabling integration with local client from web UI (i.e. when local Nextcloud clients are not used).

Use

occ config:system:set web_ui_integration_local_client.enabled --value='true' --type=boolean

to enable (default if not set) and

occ config:system:set web_ui_integration_local_client.enabled --value='false' --type=boolean

to disable integration.

Use added parameter to show/hide Edit locally option in Nextcloud Files.

Related: https://help.nextcloud.com/t/how-remove-hide-edit-locally-option-in-web-interface/171999/5
Author-Change-Id: IB#1156402

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[solracsf]

Wouldn't this make more sense in the... Web UI itself ?

[pboguslawski]

Wouldn't this make more sense in the... Web UI itself ?

It's meant for admin to be able to disable such options globally using config file not per user.

[jancborchardt]

If it’s still enabled by default (as it seems to be) and not too much of a maintenance load (@sorbaugh @skjnldsv) I’m fine with it.

[jancborchardt]

Adding @juliusknorr as he mentioned we might already have a config for this in richdocuments, and should make sure both are 1 setting only. (But possibly using this server-wide setting.)

[juliusknorr]

This makes sense for instances that do not make use of the desktop client at all. For that reason we have a setting in richdocuments, but having a global one seems more reasonable, we should adapt to respect that in richdocuments once this PR is merged (https://github.com/nextcloud/richdocuments/blob/920cf96886400abafffbc82ad414145408fd6d6d/lib/Service/InitialStateService.php#L112)

[skjnldsv]

/backport! to master

EDIT: #54191

[jancborchardt]

Btw, thinking about this again:

when local Nextcloud clients are not used

Is this not something we know, or can detect? That is, if the desktop client was never used, then "Edit locally" never needs to show. It should only show if the desktop client was used at all in the past, or even e.g. if it was used in the last x days (if it should be more intelligent).

Then we don’t need a setting for something that can be handled automatically.

[pboguslawski]

That is, if the desktop client was never used, then "Edit locally" never needs to show.

Cons:

• extra data to store/maintain per user,
• cannot disable integration globally by admin for whatever reason,
• user cannot disable it after used in the past,
• won't help in other places (like richdocuments above).

[jancborchardt]

That is, if the desktop client was never used, then "Edit locally" never needs to show.

Cons:
* extra data to store/maintain per user,

Sure, but that’s fine, the big pro is that nothing needs to be done manually. Also, we already do have that info via the devices list, don’t we?

* cannot disable integration globally by admin for whatever reason,

Yeah, but if it’s automatic I would wager that this topic would never come up.

* user cannot disable it after used in the past,

Which is why I said or even e.g. if it was used in the last x days (if it should be more intelligent) – then if the server notices that you haven’t used the desktop client in a week or a month (whatever length we decide), the menu item can vanish.

* won't help in other places (like richdocuments [above](#issuecomment-2620107898)).

Don’t we use the desktop client to do the handover in this case too? @juliusknorr could you comment on the automatic approach I proposed?