Skip to content

chore: Only show hours and minutes in first login timestamp #50305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 2 commits into from
Jan 21, 2025
Merged

chore: Only show hours and minutes in first login timestamp #50305

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a967968
chore: Only show hours and minutes in first login timestamp
Pytal Jan 21, 2025
8dd5d83
chore(assets): Recompile assets
nextcloud-command Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/settings/src/mixins/UserRowMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,13 @@ export default {
},
},
setup(props) {
const { formattedFullTime } = useFormatDateTime(props.user.firstLoginTimestamp * 1000, { relativeTime: false })
const { formattedFullTime } = useFormatDateTime(props.user.firstLoginTimestamp * 1000, {
relativeTime: false,
format: {
timeStyle: 'short',
dateStyle: 'short',
Copy link
Contributor

@susnux susnux Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the date style as short looks a bit weird in German, but thats fine if space is a problem.

Copy link
Member Author

@Pytal Pytal Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the same default as upstream https://github.com/nextcloud-libraries/nextcloud-vue/blob/50f91a9471d095fd0030ba06256eb62a6c27d525/src/composables/useFormatDateTime.ts#L54 🙈

},
})
return {
formattedFullTime,
}
Expand Down
Loading