fix(theming): remove node-vibrant dependency and usage (was moved to backend) #50320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
Pytal,
artonge and
skjnldsv
and removed request for
a team
artonge
approved these changes
Jan 22, 2025
Merged
…backend) The color extraction is handled by the backend nowadays, this was not used by the backend anymore. Reduce depdencies + compiled size + security warning on that dependency. Signed-off-by: Ferdinand Thiessen <[email protected]>
AndyScherzinger
force-pushed
the
fix/node-vibrant
branch
from
4c69f01 to
d64dc15
Compare
Member
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
AndyScherzinger
approved these changes
Jan 25, 2025
Member
|
/backport to stable31 |
Merged
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color extraction is handled by the backend nowadays, the color this calculated was not used by the backend anymore.
Reduce dependencies + compiled size + security warning on that dependency.
Checklist