fix(TaskProcessing): Cache providersById in getPreferredProviders

Signed-off-by: Marcel Klehr <[email protected]>

lib/private/TaskProcessing/Manager.php

@@ -80,6 +80,7 @@
 
 	private IAppData $appData;
 	private ?array $preferences = null;
+	private ?array $providersById = null;
 	private ICache $cache;
 	private ICache $distributedCache;
 
@@ -744,9 +745,13 @@
 
 			$providers = $this->getProviders();
 			if (isset($this->preferences[$taskTypeId])) {
-				$provider = current(array_values(array_filter($providers, fn ($provider) => $provider->getId() === $this->preferences[$taskTypeId])));
-				if ($provider !== false) {
-					return $provider;
+				$providersById = $this->providersById ?? array_reduce($providers, static function (array $carry, IProvider $provider) {
+					$carry[$provider->getId()] = $provider;
+					return $carry;
+				}, []);
+				$this->providersById = $providersById;
+				if (isset($providersById[$this->preferences[$taskTypeId]])) {
+					return $providersById[$this->preferences[$taskTypeId]];
 				}
 			}
 			// By default, use the first available provider
@@ -994,7 +999,7 @@
 				$task->setEndedAt(time());
 				$error = 'The task was processed successfully but the provider\'s output doesn\'t pass validation against the task type\'s outputShape spec and/or the provider\'s own optionalOutputShape spec';
 				$task->setErrorMessage($error);
 				$this->logger->error($error . ' Output was: ' . var_export($result, true), ['exception' => $e]);
 			} catch (NotPermittedException $e) {
 				$task->setProgress(1);
 				$task->setStatus(Task::STATUS_FAILED);