Skip to content

chore: update php intl stub and fix type issues #50452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Feb 28, 2025
Merged

chore: update php intl stub and fix type issues #50452

nickvergessen merged 2 commits into from
Feb 28, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 27, 2025 •
edited
Loading

Summary

  • Update the stub for PHP 8.0+
  • Adjust using code to comply

Checklist

@susnux susnux added 3. to review Waiting for reviews technical debt php Pull requests that update Php code ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 27, 2025
@susnux susnux added this to the Nextcloud 32 milestone Jan 27, 2025
@susnux susnux requested review from come-nc, nickvergessen and provokateurin and removed request for come-nc February 11, 2025 11:06
@susnux susnux marked this pull request as ready for review February 11, 2025 11:06
come-nc
come-nc reviewed Feb 11, 2025
View reviewed changes
provokateurin

This comment was marked as resolved.

Sign in to view

@susnux

This comment was marked as resolved.

Sign in to view
provokateurin
provokateurin approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wonder if we should have a better system in place to ensure these stubs match the lowest supported PHP version.

@nickvergessen nickvergessen merged commit fed74d7 into master Feb 28, 2025
193 checks passed
@nickvergessen nickvergessen deleted the chore/update-stub branch February 28, 2025 07:37
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews php Pull requests that update Php code ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@susnux @nickvergessen @provokateurin @come-nc @skjnldsv