Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 27, 2025

  • Resolves: #

Summary

  • Show what is the error when validating a configuration in the LDAP settings
  • Check that user base and group base are under the root base

Checklist

@come-nc come-nc added this to the Nextcloud 32 milestone Jan 27, 2025
@come-nc come-nc self-assigned this Jan 27, 2025
@come-nc
Copy link
Contributor Author

come-nc commented Jan 28, 2025

Configuration validation is weird.

  1. For an invalid configuration, it happens on each get/set, so it will spam the logs
  2. The configuration is saved before being checked, so it is saved even if not valid (there is not save button)
  3. If you click "test configuration" too fast after a change, it actually tests the previous version of the configuration, before the change.

But all of that was already like that before this PR, so I still think the PR makes sense.

@come-nc come-nc force-pushed the enh/ldap-clearer-errors branch from 6fc7454 to 2f820da Compare February 18, 2025 15:10
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 18, 2025
@come-nc come-nc requested review from artonge and blizzz February 18, 2025 15:39
@come-nc come-nc requested review from a team, Altahrim, icewind1991 and nfebe and removed request for a team February 20, 2025 17:05
@AndyScherzinger AndyScherzinger merged commit 862c3e7 into master Feb 25, 2025
190 checks passed
@AndyScherzinger AndyScherzinger deleted the enh/ldap-clearer-errors branch February 25, 2025 22:17
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants