-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Improve error detail when saving an incorrect LDAP config #50475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Configuration validation is weird.
But all of that was already like that before this PR, so I still think the PR makes sense. |
6fc7454 to
2f820da
Compare
artonge
approved these changes
Feb 18, 2025
blizzz
approved these changes
Feb 20, 2025
blizzz
reviewed
Feb 20, 2025
…uration Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
… one Signed-off-by: Côme Chilliet <[email protected]>
Co-authored-by: Arthur Schiwon <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
e382d15 to
1b81838
Compare
Signed-off-by: Andy Scherzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist