-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(performance): use low resolution for blurhash #50494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
615e628 to
826f2e3
Compare
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
juliusknorr
approved these changes
Jan 28, 2025
susnux
approved these changes
Jan 28, 2025
Contributor
Author
|
/backport to stable29 |
artonge
approved these changes
Jan 28, 2025
Contributor
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Improve blurhash performance by using a low res image. The results are hard to destinguish visualy. It is a **blur** hash after all. Signed-off-by: Max <[email protected]>
826f2e3 to
faaed68
Compare
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable31 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve blurhash performance by using a low res image.
The results are hard to destinguish visualy.
It is a blur hash after all.
Performance Impact
89 runs per minute ( up from 26)
Memory footprint of 120 MB instead of 1.1 GB.
Screenshots
Before: 300px width source
After: 30px width source
Checklist