fix(theming): Do not throw in background color migration #50503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
artonge
approved these changes
Jan 28, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
So it's fine to skip this migration?
Contributor
Author
Yes and no - the users will complain that their theming is gone. I pushed a fixup where you could see a proper fix, but that needs some hacking for MySQL due to its limitations (subquery table for select must not be the same as the update table, but with a third select it works). |
susnux
force-pushed
the
fix/theming-migration
branch
from
cbb4a60 to
eaa2e9b
Compare
provokateurin
approved these changes
Jan 28, 2025
susnux
force-pushed
the
fix/theming-migration
branch
from
eaa2e9b to
321b65e
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/theming-migration
branch
from
e9e57fb to
bf7dc2f
Compare
nickvergessen
approved these changes
Jan 29, 2025
This was referenced Jan 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some users already set up a custom background color than this does not work.
So we need to catch on those cases.