fix: Send password to owner when password sending fails, regardless of enforcement #50517
+48
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
provokateurin
requested changes
Jan 29, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Tests need to be adjusted
nfebe
force-pushed
the
fix/50512/send-password-2-owner
branch
2 times, most recently
from
beacb35 to
362ba1a
Compare
Member
|
Needs a rebase (not sure why the other commit still shows up here) and tests need to be adjusted. |
Contributor
Author
This was branched of the ticket mentioned in the description as "uses".
|
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
…f enforcement Previously, the `sendPasswordToOwner` method would only trigger if password enforcement was enabled and sending the password to the recipient failed. This behavior was inconsistent with the intended functionality, as the owner should receive the password whenever sending to the recipient fails, regardless of whether password enforcement is enabled. This change ensures that the owner is notified of the password whenever sending it to the recipient fails, improving consistency and user experience. Signed-off-by: nfebe <[email protected]>
…disabled Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/50512/send-password-2-owner
branch
from
97645e4 to
d652cd1
Compare
nfebe
requested review from
ArtificialOwl and
provokateurin
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
sendPasswordToOwnermethod would only trigger if password enforcement was enabled and sending the password to the recipient failed. This behavior was inconsistent with the intended functionality, as the owner should receive the password whenever sending to the recipient fails, regardless of whether password enforcement is enabled.This change ensures that the owner is notified of the password whenever sending it to the recipient fails, improving consistency and user experience.
Fixes : #50512
Uses : #50515