Skip to content

refactor(encoding): Check if strings are valid ASCII #50526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solracsf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(encoding): Check if strings are valid ASCII #50526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(encoding): Check if strings are valid for the specified enco… 
…ding

Signed-off-by: Git'Fellow <[email protected]>
  • Loading branch information
@solracsf
solracsf authored Jan 29, 2025
commit f3b4fdccd0b538a161729a3dd990ffc0a2573561
2 changes: 1 addition & 1 deletion lib/private/Files/Storage/Wrapper/Encoding.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function __construct(array $parameters) {
* Returns whether the given string is only made of ASCII characters
*/
private function isAscii(string $str): bool {
return !preg_match('/[\\x80-\\xff]+/', $str);
return mb_check_encoding($str, 'ASCII');
}

/**
Expand Down
Loading