-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard #50530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
nfebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the any auto tests for this?
No unfortunately not, as changing the DB inside the tests is not a good idea. I still want to add a test for it later though, but will have to see in what form. |
…feguard Signed-off-by: Nils Wenninghoff <[email protected]>
Signed-off-by: provokateurin <[email protected]>
1ce1990 to
d8cc8aa
Compare
Summary
Fixes #45257
Unforked version of #48666.
While testing I also found that #39242 read the hostname wrong which never worked.
I tested it successfully like this (make sure to have
pdo_pgsqlenabled):Checklist