Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 31, 2025

Summary

  • Clarify that enabling server side encryption will not encrypt existing files but only new or changed files.
  • Clarify that server side encryption can only be disabled using OCC
  • Ensure there is accessible information of encryption state (disabled input will not be announced so make it aria-disabled instead)
  • Make warning more prominent by moving it into a dialog

- Clarify that enabling server side encryption will not encrypt
  existing files but only new or changed files.
- Clarify that server side encryption can only be disabled using OCC
- Ensure there is accessible information of encryption state (`disabled`
  input will not be announced so make it `aria-disabled` instead)
- Make warning more prominent by moving it into a dialog

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux changed the title fix(settings): Clarify peculiarities of enabling encryption [stable30] fix(settings): Clarify peculiarities of enabling encryption Jan 31, 2025
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux
Copy link
Contributor Author

susnux commented Jan 31, 2025

Manually checked that all changes are applied ✅

@susnux susnux requested a review from Pytal January 31, 2025 16:48
@susnux susnux self-assigned this Jan 31, 2025
@susnux susnux enabled auto-merge January 31, 2025 17:47
@susnux susnux merged commit 6a55819 into stable30 Feb 3, 2025
113 checks passed
@susnux susnux deleted the backport/50424/stable30 branch February 3, 2025 10:01
@Altahrim Altahrim mentioned this pull request Feb 5, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants