Skip to content

[stable31] chore(files): Adjust wording #50641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 4 commits into from
Feb 4, 2025
Merged

[stable31] chore(files): Adjust wording #50641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9485869
chore(files): Change "filename" to "file name"
Pytal Feb 3, 2025
16bd639
fix(files): Fix casing
Pytal Feb 3, 2025
d5532a9
chore(cypress): Finish comment
Pytal Feb 3, 2025
009ddd1
chore(assets): Recompile assets
nextcloud-command Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files/src/views/Navigation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class="files-navigation"
:aria-label="t('files', 'Files')">
<template #search>
<NcAppNavigationSearch v-model="searchQuery" :label="t('files', 'Filter filenames…')" />
<NcAppNavigationSearch v-model="searchQuery" :label="t('files', 'Filter file names…')" />
</template>
<template #default>
<NcAppNavigationList class="files-navigation__list"
Expand Down
2 changes: 1 addition & 1 deletion apps/files/src/views/personal-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default () => {
const Navigation = getNavigation()
Navigation.register(new View({
id: 'personal',
name: t('files', 'Personal Files'),
name: t('files', 'Personal files'),
caption: t('files', 'List of your files and folders that are not shared.'),

emptyTitle: t('files', 'No personal files found'),
Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/files/files-filtering.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ describe('files: Filter in files list', { testIsolation: true }, () => {
navigateToFolder('folder')
getRowForFile('folder').should('not.exist')

// See that the chip is still
// See that the chip is still active
filesFilters.activeFilters()
.should('have.length', 1)
.contains(/Folder/).should('be.visible')
Expand Down Expand Up @@ -265,7 +265,7 @@ describe('files: Filter in files list', { testIsolation: true }, () => {

// go to other view
appNavigation.views()
.findByRole('link', { name: /Personal Files/i })
.findByRole('link', { name: /personal files/i })
.click()
// wait for view changed
cy.url().should('match', /apps\/files\/personal/)
Expand Down
2 changes: 1 addition & 1 deletion cypress/pages/FilesNavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class FilesNavigationPage {
}

searchInput() {
return this.navigation().findByRole('searchbox', { name: /filter filenames/i })
return this.navigation().findByRole('searchbox', { name: /filter file names/i })
}

searchClearButton() {
Expand Down
4 changes: 2 additions & 2 deletions dist/files-init.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-init.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/files-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading