Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 5, 2025

Fix #42902

  • Fix extension handling
  • Added phpunit tests

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Feb 5, 2025
@skjnldsv skjnldsv requested review from a team, kesselb and tcitworld February 5, 2025 10:52
@skjnldsv skjnldsv self-assigned this Feb 5, 2025
@skjnldsv skjnldsv requested review from Altahrim, come-nc and icewind1991 and removed request for a team February 5, 2025 10:52
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 5, 2025

/backport to stable31

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 5, 2025

/backport to stable30

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 5, 2025

/backport to stable29

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

susnux
susnux previously requested changes Feb 5, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type of interface and implementation does not match

Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv merged commit 93c72f5 into master Feb 6, 2025
182 of 189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to set .0 through .9 as mimetypemapping.json

6 participants