fix(files): Do not download files with openfile query flag #50669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
artonge and
sorbaugh
and removed request for
a team
AndyScherzinger
approved these changes
Feb 5, 2025
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
susnux
force-pushed
the
fix/files-show-details-when-no-action
branch
2 times, most recently
from
ec4a79f to
6b0f942
Compare
Instead of downloading files, if there is no other default action, we should just open the details tab. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-show-details-when-no-action
branch
from
0e96fb6 to
fcdfb9e
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/50669/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick dbc5c10b fcdfb9ef
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50669/stable30Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
Contributor
Author
|
/backport to stable30 |
2 tasks
Contributor
Author
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/50669/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick dbc5c10b fcdfb9ef
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50669/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
susnux
added a commit
that referenced
this pull request
Feb 28, 2025
…nt route Missing piece from #50669 as we also need to adjust the files sharing router otherwiese we can get those exceptions. Signed-off-by: Ferdinand Thiessen <[email protected]>
4 tasks
susnux
added a commit
that referenced
this pull request
Mar 4, 2025
…nt route Missing piece from #50669 as we also need to adjust the files sharing router otherwiese we can get those exceptions. Signed-off-by: Ferdinand Thiessen <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
…nt route Missing piece from #50669 as we also need to adjust the files sharing router otherwiese we can get those exceptions. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added a commit
that referenced
this pull request
Mar 4, 2025
…nt route Missing piece from #50669 as we also need to adjust the files sharing router otherwiese we can get those exceptions. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added a commit
that referenced
this pull request
Mar 4, 2025
…nt route Missing piece from #50669 as we also need to adjust the files sharing router otherwiese we can get those exceptions. Signed-off-by: Ferdinand Thiessen <[email protected]>
SebastianKrupinski
pushed a commit
that referenced
this pull request
May 8, 2025
…nt route Missing piece from #50669 as we also need to adjust the files sharing router otherwiese we can get those exceptions. Signed-off-by: Ferdinand Thiessen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
openfileis set on a folder or file that cannot be opened (there is no app for it) we should not download it.Instead we should show the sidebar (
opendetails) and let the user decide to download it.Checklist