Skip to content

[stable30] fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize #50682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Feb 13, 2025
Merged

[stable30] fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize #50682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be1759f
fix(TaskProcessing\Manager): Always use distributed cache and use PHP…
marcelklehr Feb 4, 2025
befca3e
fix(TaskProcessing\Manager): Always use distributed cache and use PHP…
marcelklehr Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/private/TaskProcessing/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class Manager implements IManager {
private IAppData $appData;
private ?array $preferences = null;
private ?array $providersById = null;
private ICache $cache;
private ICache $distributedCache;

public function __construct(
Expand All @@ -101,7 +100,6 @@ public function __construct(
ICacheFactory $cacheFactory,
) {
$this->appData = $appDataFactory->get('core');
$this->cache = $cacheFactory->createLocal('task_processing::');
$this->distributedCache = $cacheFactory->createDistributed('task_processing::');
}

Expand Down Expand Up @@ -741,8 +739,10 @@ public function getPreferredProvider(string $taskTypeId) {

public function getAvailableTaskTypes(): array {
if ($this->availableTaskTypes === null) {
// We use local cache only because distributed cache uses JSOn stringify which would botch our ShapeDescriptor objects
$this->availableTaskTypes = $this->cache->get('available_task_types');
$cachedValue = $this->distributedCache->get('available_task_types_v2');
if ($cachedValue !== null) {
$this->availableTaskTypes = unserialize($cachedValue);
}
}
if ($this->availableTaskTypes === null) {
$taskTypes = $this->_getTaskTypes();
Expand Down Expand Up @@ -775,7 +775,7 @@ public function getAvailableTaskTypes(): array {
}

$this->availableTaskTypes = $availableTaskTypes;
$this->cache->set('available_task_types', $this->availableTaskTypes, 60);
$this->distributedCache->set('available_task_types_v2', serialize($this->availableTaskTypes), 60);
}

return $this->availableTaskTypes;
Expand Down
Loading