fix(emailTemplate): use instance Name instead of Url in subject

[solracsf]

Summary

A lot of anti-spam systems doesn't like plain URLs on the email subject (ex.: Orange in France) and place those emails on Junk folder. Use instance Name instead (URL is kept on email body).

Before

Email address for Carroll, Mathieu changed on https://cloud.my-personal-cloud.org/

After

Email address for Carroll, Mathieu changed on My Personal Cloud

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[jancborchardt]

Sounds like it makes sense, we don’t need a link in the subject. :) Thanks a bunch @solracsf!

[come-nc]

Hum, but instance name is often simply Nextcloud, no?

[solracsf]

All Activity and Notifications emails (so, 99.9% of emails received) have instance name.
I would even say that ALL other emails have instance name.

Examples:

https://github.com/nextcloud/activity/blob/8c24838746977dd1dca04c9d07b0693d41777cde/lib/DigestSender.php#L167

https://github.com/nextcloud/notifications/blob/b98345d686dcccce533c2f2a088c765eab3f92b2/lib/MailNotifications.php#L208

[come-nc]

Fair enough.

[jancborchardt]

@come-nc @solracsf what about the failing tests?

[solracsf]

They don't seem related.

[susnux]

@jancborchardt unrelated, flaky tests 😔

[AndyScherzinger]

/backport to stable31