Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 6, 2025

Backport of #50626

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge and nfebe February 6, 2025 13:37
@backportbot backportbot bot added enhancement 3. to review Waiting for reviews labels Feb 6, 2025
@backportbot backportbot bot added this to the Nextcloud 29.0.12 milestone Feb 6, 2025
@nfebe nfebe force-pushed the backport/50626/stable29 branch from 17dfa40 to 915de27 Compare February 6, 2025 13:40
@nfebe nfebe changed the title [stable29] [stable30] chore : Comprehensive e2e testing for public sharing [stable29] chore : Comprehensive e2e testing for public sharing Feb 6, 2025
@nfebe
Copy link
Contributor

nfebe commented Feb 6, 2025

/compile

@nfebe nfebe marked this pull request as ready for review February 6, 2025 14:09
@nfebe nfebe requested review from Pytal and susnux February 6, 2025 14:09
@Altahrim Altahrim mentioned this pull request Feb 11, 2025
6 tasks
@susnux susnux force-pushed the backport/50626/stable29 branch from e9a9d46 to f94a149 Compare February 11, 2025 16:05
nfebe and others added 4 commits February 11, 2025 17:16
This addition enhances the testing framework for public sharing by
improving the setup and management of share contexts.

Additionally, the update optimizes share permission adjustments and
improves state management, making public share setups more efficient and maintainable.

Signed-off-by: nfebe <[email protected]>
This commit introduces end-to-end tests for various public link sharing scenarios in the `files_sharing` app. It validates the behavior under multiple configurations:

- Password and expiration date enforced
- Password enforced with a default expiration date
- Expiration date enforced with optional password
- Default password and expiration date without enforcement
- Password enforced, expiration date set but not enforced
- Both password and expiration date not enforced, but defaults set
- Password not enforced, expiration date enforced
- Password not enforced, default expiration date set
- Password and expiration date not enforced with no defaults

The tests ensure proper validation and functionality of the configurations, leveraging the `setupData` and `createShare` utilities.

Signed-off-by: nfebe <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux force-pushed the backport/50626/stable29 branch from f94a149 to df5ffb1 Compare February 11, 2025 16:17
@Altahrim Altahrim merged commit ef2226a into stable29 Feb 11, 2025
112 of 113 checks passed
@Altahrim Altahrim deleted the backport/50626/stable29 branch February 11, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants