Skip to content

fix(files_reminders): Only allow updating reminders if the file is accessible #50711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 3 commits into from
Feb 20, 2025
Merged

fix(files_reminders): Only allow updating reminders if the file is accessible #50711

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdf6db0
fix(files_reminders): Only allow updating reminders if the file is ac…
Pytal Feb 6, 2025
55351cf
fix(files_reminders): Check for node access when retrieving or removi…
Pytal Feb 6, 2025
fd591b0
fix(lint): remove whitespaces
AndyScherzinger Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(lint): remove whitespaces 
Signed-off-by: Andy Scherzinger <[email protected]>
  • Loading branch information
@AndyScherzinger
AndyScherzinger committed Feb 20, 2025
commit fd591b0b9b9209d88b19ca5d0a9302b4b1e6028e
4 changes: 2 additions & 2 deletions apps/files_reminders/lib/Controller/ApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function get(int $fileId): DataResponse {
'dueDate' => $reminder->getDueDate()->format(DateTimeInterface::ATOM), // ISO 8601
];
return new DataResponse($reminderData, Http::STATUS_OK);
} catch (NodeNotFoundException | DoesNotExistException $e) {
} catch (NodeNotFoundException|DoesNotExistException $e) {
$reminderData = [
'dueDate' => null,
];
Expand Down Expand Up @@ -125,7 +125,7 @@ public function remove(int $fileId): DataResponse {
try {
$this->reminderService->remove($user, $fileId);
return new DataResponse([], Http::STATUS_OK);
} catch (NodeNotFoundException | DoesNotExistException $e) {
} catch (NodeNotFoundException|DoesNotExistException $e) {
return new DataResponse([], Http::STATUS_NOT_FOUND);
}
}
Expand Down
Loading