Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 14, 2025

Fix #50629
Regression from #37065

@Pytal since you did the other PR, I'm not sure what this was about.
On mount if there is none we don't show it, is that so?
I guess this have been replaced by #40939 as we now save the current show/hide state ?

Vue fix

First commit also fixes the undebuggable state of the sidebar in the vue dev tools 🥹
image

@skjnldsv skjnldsv requested review from Pytal, nfebe and susnux February 14, 2025 15:12
@skjnldsv skjnldsv self-assigned this Feb 14, 2025
@skjnldsv skjnldsv requested a review from GretaD February 14, 2025 15:13
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Feb 14, 2025
@skjnldsv
Copy link
Member Author

/backport 6c8c80d to stable30

@skjnldsv
Copy link
Member Author

/backport 6c8c80d to stable29

@skjnldsv
Copy link
Member Author

/backport to stable31

@Pytal
Copy link
Member

Pytal commented Feb 14, 2025

@Pytal since you did the other PR, I'm not sure what this was about. On mount if there is none we don't show it, is that so?

Yes, was a design request iirc

Maybe check the behaviour with @marcoambrosini

@solracsf solracsf added this to the Nextcloud 32 milestone Feb 14, 2025
@skjnldsv skjnldsv changed the title fix(files): attach sidebar to main content for vue debug fix(systemtags): do not hide if no tags Feb 18, 2025
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it fixes #50629.

@susnux
Copy link
Contributor

susnux commented Feb 18, 2025

/compile

Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit 9f108d8 into master Feb 18, 2025
119 checks passed
@susnux susnux deleted the fix/tags branch February 18, 2025 16:40
@backportbot

This comment was marked as resolved.

@backportbot

This comment was marked as resolved.

@st3iny
Copy link
Member

st3iny commented Feb 18, 2025

Auto backports failed 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: file sidebar Related to the file sidebar component feature: files regression

Projects

None yet

7 participants