fix: block downloading of files with 'hide download' option

[AIlkiv]

• Resolves: #

Summary

If you make a public share with the “hide download” option, the download button is hidden, but the direct link allows you to get the file.

This fix fixes it.

I understand that there are different ways to download a file. The point here is to reduce the number of such places.

TODO

• Create link for image
  

• Example http://nextcloud.local/index.php/s/p98WonbBMd8PFcX

• Can be downloaded at the link http://nextcloud.local/index.php/s/p98WonbBMd8PFcX**/download**

• After fix
  

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

This is not fully true as hide download and forbid download are two distinct permissions on Nextcloud.

[AIlkiv]

This is not fully true as hide download and forbid download are two distinct permissions on Nextcloud.

@susnux
I think that these are not different options, but a conflict in implementation. Because one option is used for sharing between users, and the other for public links.

In any case, as I wrote in the description, this is not a solution to a global issue, this fix reduces the number of problematic places.

[susnux]

I think that these are not different options, but a conflict in implementation. Because one option is used for sharing between users, and the other for public links.

They are. There is hideDownload on the share and there is the download permissions attribute on the share.
The hideDownload flag is not intended to prevent downloading it only hides the UI buttons.

In any case, as I wrote in the description, this is not a solution to a global issue, this fix reduces the number of problematic places.

But this is checking the wrong permission.

[AIlkiv]

When creating a share link, there is no option to “Allow download”

[susnux]

Thats right, because public shares and internal shares have two different download permissions:
Something discussed here: #46256

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)