feat: Support deleting metadata from WebDAV #50852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
enhancement
3. to review
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
artonge
added a commit
to nextcloud/documentation
that referenced
this pull request
Feb 17, 2025
After: nextcloud/server#50852 Signed-off-by: Louis Chemineau <[email protected]>
susnux
reviewed
Feb 17, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Could you add a (integration) test for this?
artonge
added a commit
to nextcloud/documentation
that referenced
this pull request
Feb 17, 2025
After: nextcloud/server#50852 Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/allow_deleting_metadata
branch
3 times, most recently
from
cab3796 to
ad3815a
Compare
come-nc
reviewed
Mar 4, 2025
The `$value` will be `null` if the update is wrapped inside a `<d:remove>...</d:remove>` block. Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/allow_deleting_metadata
branch
from
ad3815a to
c2f2f21
Compare
come-nc
approved these changes
Mar 4, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
indentation in metadata.feature is weird
provokateurin
approved these changes
Mar 4, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Now this makes sense to me 😅
This was referenced Mar 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$valuewill benullif the update is wrapped inside a<d:remove>...</d:remove>block.