refactor(files): Remove App class and move files.max_chunk_size to JSConfigHelper #50875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
added
3. to review
provokateurin
requested review from
a team,
Altahrim,
skjnldsv and
sorbaugh
and removed request for
a team
provokateurin
force-pushed
the
refactor/files/remove-app-class
branch
from
3531bd8 to
e5d78e2
Compare
skjnldsv
approved these changes
Feb 18, 2025
ArtificialOwl
approved these changes
Feb 24, 2025
Signed-off-by: provokateurin <[email protected]>
…ConfigHelper Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
refactor/files/remove-app-class
branch
from
e5d78e2 to
ade062a
Compare
Member
Author
|
Rebased to hopefully fix cypress? |
susnux
requested changes
Feb 24, 2025
susnux
approved these changes
Feb 24, 2025
provokateurin
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The navigation manager is never used in the server code, so the functionality from Circles was never doing anything: nextcloud/circles#1877
Instead of using the "hack" with the hook to modify the config I just inlined it to make it simpler and get rid of the class.
I couldn't find any other usage of this specific hook, so I think it is fine to just remove it completely.
Checklist