fix(dav): Handle end of stream in File::put
#50881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the stream is aborted and the callback wrapper returns false (or null as it happened in some cases), we should not try to write to the storage but abort the operation. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
ArtificialOwl,
icewind1991,
mahibi and
sorbaugh
Contributor
Author
|
(I would like to add tests but I do not see how to mock the static class method of |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
AndyScherzinger
approved these changes
Feb 27, 2025
yemkareems
approved these changes
Feb 28, 2025
skjnldsv
approved these changes
Feb 28, 2025
Member
|
Let e adjust the cypress test @susnux |
This was referenced Feb 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the stream is aborted and the callback wrapper returns false (or null as it happened in some cases), we should not try to write to the storage but abort the operation.
Checklist