AppFramework add default values (ApiController) as parameters

[rullzer]

This means that a controller inherriting from the ApiController and not
implementing their own constructor would fail.

• Unit tests updated

Found this while helping @schiessle debug.
CC: @BernhardPosselt @nickvergessen @MorrisJobke @LukasReschke

[mention-bot]

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @BernhardPosselt, @Xenopathic and @DeepDiver1975 to be potential reviewers

[rullzer]

https://github.com/nextcloud/server/pull/509/files?w=1 for easier review 😉

[BernhardPosselt]

Why not simply put the next try catch into the catch block? continue is super confusing here

[BernhardPosselt]

Actually unsure if this is a good idea since adding default parameters will make the container always ignore them.

I'd probably make the parent constructor protected since the class is abstract anyways, that would require you to call the parent method and prevent these mistakes. Unfortunately there's no operator overloading in PHP.

Another approach would be to also define these defaults in the container so it actually works

[rullzer]

Another approach would be to also define these defaults in the container so it actually works

Oeee I like that....
Let me change this PR.

[rullzer]

I'd probably make the parent constructor protected since the class is abstract anyways, that would require you to call the parent method and prevent these mistakes. Unfortunately there's no operator overloading in PHP.

We can't really do that. because if we want to make the OCSControllers constructor protected we have to make the APIControllers constructor private and then would mean making the Controllers constrcutor private.

[rullzer]

@BernhardPosselt this looks cleaner indeed

[nickvergessen]

We can't really do that. because if we want to make the OCSControllers constructor protected we have to make the APIControllers constructor private and then would mean making the Controllers constrcutor private.

Not really, you can make protected methods public on extends: https://3v4l.org/NL1gv

[rullzer]

@nickvergessen yes but it is the other way around https://3v4l.org/qHXuO

[MorrisJobke]

@rullzer Could you explain what this does and how to verify it works?

[nickvergessen]

Could you explain what this does and how to verify it works?

1. Create a controller, and do not add the constructor.
2. Use automatic DI (server->query('Class')) to get an instance
3. See how it (not) throws

[nickvergessen]

👍

[MorrisJobke]

👍