Skip to content

[stable30] fix(files_external): request strict password auth on credentials enter action #50931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 6 commits into from
Feb 21, 2025
Merged

[stable30] fix(files_external): request strict password auth on credentials enter action #50931

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84eaba6
fix(files_external): request strict password auth on credentials ente…
skjnldsv Feb 19, 2025
05f3f2d
chore(files_external): add cypress tests for user credentials action
skjnldsv Feb 20, 2025
47cde4c
fix(files_external): inline storage check improvements
skjnldsv Feb 20, 2025
01ffa31
chore(cypress): also log the current server image sha
skjnldsv Feb 20, 2025
0394037
fix(cypress): action selector menu lookup
skjnldsv Feb 20, 2025
d84cd4f
chore(assets): Recompile assets
nextcloud-command Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files_external): request strict password auth on credentials ente… 
…r action

Signed-off-by: skjnldsv <[email protected]>
  • Loading branch information
@skjnldsv @backportbot
skjnldsv authored and backportbot[bot] committed Feb 20, 2025
commit 84eaba63a8b5f9eca8ca0985f11d0f93b4168e46
5 changes: 5 additions & 0 deletions apps/files_external/src/actions/enterCredentialsAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import type { AxiosResponse } from '@nextcloud/axios'
import type { Node } from '@nextcloud/files'
import type { StorageConfig } from '../services/externalStorage'

import { addPasswordConfirmationInterceptors, PwdConfirmationMode } from '@nextcloud/password-confirmation'
import { generateUrl } from '@nextcloud/router'
import { showError, showSuccess, spawnDialog } from '@nextcloud/dialogs'
import { translate as t } from '@nextcloud/l10n'
Expand All @@ -18,6 +19,10 @@ import { FileAction, DefaultType } from '@nextcloud/files'
import { STORAGE_STATUS, isMissingAuthConfig } from '../utils/credentialsUtils'
import { isNodeExternalStorage } from '../utils/externalStorageUtils'

// Add password confirmation interceptors as
// the backend requires the user to confirm their password
addPasswordConfirmationInterceptors(axios)

type CredentialResponse = {
login?: string,
password?: string,
Expand Down