fix: wipe local storages on log out #50956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
approved these changes
Feb 21, 2025
susnux
reviewed
Feb 21, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Should be enough to only adjust the target which will do it automatically, so we do not duplicate the clearing logic.
susnux
reviewed
Feb 22, 2025
ShGKme
approved these changes
Feb 24, 2025
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/wipe-local-storage
branch
from
745bcaf to
afd27f4
Compare
Contributor
Author
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
Contributor
Author
|
/backport afd27f4 to stable31 |
Contributor
Author
|
/backport afd27f4 to stable30 |
Contributor
Author
|
/backport afd27f4 to stable29 |
This was referenced Feb 24, 2025
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If session was determined as 'terminated', it makes sense to clear local storages (to not interfere with the next login, and to wipe any sensitive information)
Checklist