Skip to content

Conversation

@pulsejet
Copy link
Member

@pulsejet pulsejet commented Feb 26, 2025

Fixes crash when calling Sidebar::open() from Memories.

EDIT: It's been a while I can't remember the process .. should I compile the JS in the first commit or with the bot?

@artonge
Copy link
Contributor

artonge commented Feb 27, 2025

EDIT: It's been a while I can't remember the process .. should I compile the JS in the first commit or with the bot?

Both are ok :).

@pulsejet pulsejet force-pushed the pulsejet-patch-share-attr branch from a34635f to b047461 Compare February 27, 2025 11:03
@pulsejet
Copy link
Member Author

/compile amend /

Signed-off-by: Varun Patil <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the pulsejet-patch-share-attr branch from b047461 to dbef697 Compare February 27, 2025 11:10
@skjnldsv skjnldsv merged commit 7bab703 into master Feb 27, 2025
121 checks passed
@skjnldsv skjnldsv deleted the pulsejet-patch-share-attr branch February 27, 2025 11:50
@skjnldsv
Copy link
Member

/backport to stable31

@skjnldsv
Copy link
Member

/backport to stable30

@skjnldsv
Copy link
Member

/backport to stable29

@backportbot

This comment was marked as resolved.

@skjnldsv
Copy link
Member

Not needed for older branches

@backportbot

This comment was marked as resolved.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sidebar in Photos App is empty since 31.0.0

4 participants