[stable26] feat: Close sessions created for login flow v2 #51085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
3. to review
artonge
force-pushed
the
backport/51051/stable26
branch
from
f9327a9 to
8e27cce
Compare
artonge
approved these changes
Mar 3, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php
Fixed
Show fixed
Hide fixed
lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php
Fixed
Show fixed
Hide fixed
artonge
force-pushed
the
backport/51051/stable26
branch
from
71076a9 to
0d2f2df
Compare
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser. This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request. Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
backport/51051/stable26
branch
from
0d2f2df to
8d0ff42
Compare
artonge
added
4. to release
AndyScherzinger
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #51051
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.