fix: Do not build encrypted password if there is none #51130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
3. to review
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable30 |
provokateurin
requested changes
Feb 28, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Sounds like something that requires a test to avoid regressions.
pabzm
approved these changes
Feb 28, 2025
Member
pabzm
left a comment
pabzm
left a comment
There was a problem hiding this comment.
Apart from the minor style suggestion it looks good to me! 👍
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/credential-passwordless-auth
branch
from
666a017 to
777cd94
Compare
Member
Author
|
Pushed a unit test |
provokateurin
approved these changes
Mar 6, 2025
This was referenced Mar 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #48915 where user backends without passwords would store an encrypted empty password for new app passwords.
While they first work, after 5 minutes the password is checked and cannot be validated as there is none so the token expired.
Checklist