Skip to content

ci: give request-review action permissions to fetch teams #51140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
susnux wants to merge 1 commit into from
Closed

ci: give request-review action permissions to fetch teams #51140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/request-reviews.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,11 @@ jobs:
# Only if there are not already reviews requested
if: github.event.pull_request.requested_reviewers[1] == null

permissions:
pull-requests: write
Copy link
Contributor Author

@susnux susnux Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is no longer needed, no?
As we now use the PAT permissions.


steps:
- name: Assign backend engineers
Copy link
Member

@skjnldsv skjnldsv Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Assign backend engineers
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not run this action on forks'
exit 1
- name: Assign backend engineers

Copy link
Contributor Author

@susnux susnux Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then this does not make much sense as most PRs we need this come from new community people.
We should probably just add the teams to the codeowners

if: needs.changes.outputs.backend == 'true'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_TOKEN: ${{ secrets.COMMAND_BOT_PAT }}
Copy link
Member

@nickvergessen nickvergessen Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we need to restrict it and can not run it for forks...

Copy link
Contributor Author

@susnux susnux Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot run it for forks

would be bad. But we either need a PAT or a GitHub App token.
Otherwise we need to choose the CODEOWNERS way.

Copy link
Member

@skjnldsv skjnldsv Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @nickvergessen means is this I think

      - name: Disabled on forks
        if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
        run: |
          echo 'Can not run this action on forks'
          exit 1

run: |
gh api \
--method POST \
Expand All @@ -68,7 +65,7 @@ jobs:
- name: Assign frontend engineers
if: needs.changes.outputs.frontend == 'true'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_TOKEN: ${{ secrets.COMMAND_BOT_PAT }}
run: |
gh api \
--method POST \
Expand Down
Loading