feat: Add appconfig to disable fixed userfolder permissions optimization #51145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
skjnldsv and
yemkareems
and removed request for
a team
icewind1991
force-pushed
the
home-folder-readonly
branch
3 times, most recently
from
0b62c0e to
1b40100
Compare
artonge
reviewed
Mar 3, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Feels like a hack, but I guess there is no better way to do it.
Is that optimization really worth it?
Contributor
|
Fix for #51409 |
icewind1991
force-pushed
the
home-folder-readonly
branch
from
1b40100 to
b80b473
Compare
Member
Author
For sure 🙈
Not that I can think of
It saves 1 or more cache operation for most requests and is applicable on 99%+ of instances so I would say so |
icewind1991
force-pushed
the
home-folder-readonly
branch
from
b80b473 to
f5c5279
Compare
Contributor
|
Tested. Works. Properly disables the button when a root folder is read only.
|
SebastianKrupinski
approved these changes
Jun 3, 2025
icewind1991
force-pushed
the
home-folder-readonly
branch
from
f5c5279 to
b313aae
Compare
come-nc
requested changes
Jun 23, 2025
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
artonge
force-pushed
the
home-folder-readonly
branch
from
b313aae to
e415894
Compare
artonge
added a commit
to nextcloud/groupfolders
that referenced
this pull request
Sep 25, 2025
- Related to nextcloud/server#51145 Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
home-folder-readonly
branch
from
8139991 to
d401c77
Compare
artonge
changed the title
artonge
force-pushed
the
home-folder-readonly
branch
3 times, most recently
from
2992b5e to
f314cac
Compare
artonge
added a commit
to nextcloud/groupfolders
that referenced
this pull request
Sep 25, 2025
- Related to nextcloud/server#51145 Signed-off-by: Louis Chemineau <[email protected]>
artonge
added a commit
to nextcloud/groupfolders
that referenced
this pull request
Sep 25, 2025
- Related to nextcloud/server#51145 Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
home-folder-readonly
branch
2 times, most recently
from
0ba0756 to
a3f7ed0
Compare
artonge
added a commit
to nextcloud/groupfolders
that referenced
this pull request
Sep 26, 2025
- Related to nextcloud/server#51145 Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
home-folder-readonly
branch
2 times, most recently
from
3b20fb7 to
079c883
Compare
…ons optimization Signed-off-by: Robin Appelman <[email protected]> Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
home-folder-readonly
branch
from
079c883 to
2a7add4
Compare
Merged
artonge
force-pushed
the
home-folder-readonly
branch
from
2a7add4 to
a250013
Compare
Member
Author
|
👍 |
…mounted at / exists Signed-off-by: Robin Appelman <[email protected]> Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
home-folder-readonly
branch
from
a250013 to
1ab6dba
Compare
come-nc
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to save having to fetch the metadata of the home folder in many cases, we always assume the same value for the permissions of the home folder.
This does however break if the admin has configured an external storage mounted at
/with different permissions.To fix those cases without breaking the optimization for other instances, this adds a flag in the appconfig to disable the optimization and actually fetch the correct permissions.
This flag is automatically set by the files_external app when such an external storage is detected
To test:
/and set as readonlyGroupfolders counterpart: nextcloud/groupfolders#4017